Skip to content

Axum docker build action#20

Merged
ChristianPavilonis merged 4 commits intomainfrom
feature/docker-build
Feb 9, 2026
Merged

Axum docker build action#20
ChristianPavilonis merged 4 commits intomainfrom
feature/docker-build

Conversation

@ChristianPavilonis
Copy link
Copy Markdown
Contributor

@ChristianPavilonis ChristianPavilonis commented Jan 27, 2026

Updates Cargo.toml to use https:// instead of ssh for public edgezero repo and adds docker build

@ChristianPavilonis ChristianPavilonis marked this pull request as ready for review January 27, 2026 19:12
Copy link
Copy Markdown
Contributor

@aram356 aram356 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start but need small tweaks

@ChristianPavilonis
Copy link
Copy Markdown
Contributor Author

All review comments addressed:

  1. .cargo/config.toml.local - Restored
  2. Dockerfile Rust version sync with .tool-versions:
    • Dockerfile:1-2 - ARG RUST_VERSION with parameterized FROM
    • .github/workflows/docker.yml:30-32 - Reads version from .tool-versions
    • .github/workflows/docker.yml:65 - Passes as build-arg
  3. Release trigger with tag_name:
    • .github/workflows/docker.yml:4-5 - release trigger
    • .github/workflows/docker.yml:47 - Uses github.event.release.tag_name
  4. Removed custom tag input:
    • .github/workflows/docker.yml:6-11 - Only ref input for workflow_dispatch
    • .github/workflows/docker.yml:48 - Uses ref/branch name for manual dispatch tags
  5. Concurrency group:
    • .github/workflows/docker.yml:18 - Uses release.tag_name || run_id

@aram356 aram356 requested a review from prk-Jr February 5, 2026 21:04
Copy link
Copy Markdown
Contributor

@aram356 aram356 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@ChristianPavilonis ChristianPavilonis merged commit c9adc7e into main Feb 9, 2026
4 checks passed
@aram356 aram356 deleted the feature/docker-build branch February 10, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants