Conversation
stackptr
force-pushed
the
corey/fix-spore-use-lib.mkforce-to-override-gc-options-from-base-module
branch
2 times, most recently
from
43000fd to
a2b4a35
Compare
The base gc.nix sets nix.gc.options; spore's override conflicted without mkForce. Also adds a fast eval-only CI job that checks all NixOS configurations evaluate before the full build runs, catching option conflicts like this at PR time.
stackptr
force-pushed
the
corey/fix-spore-use-lib.mkforce-to-override-gc-options-from-base-module
branch
from
a2b4a35 to
f5e21c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nix.gc.datesandnix.gc.optionsdefinitions on spore by usinglib.mkForce, allowing host-level overrides of the basegc.nixmodule defaultsevalCI job that evaluates all host configurations (glyph, spore, zeta, Rhizome) without building, gating the full build matrix — catches option conflicts and eval errors before any expensive runners spin up