Merged
Conversation
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
stackptr
force-pushed
the
feat-surface-eval-warnings
branch
from
53f3687 to
4331bf1
Compare
Owner
Author
stackptr
added a commit
that referenced
this pull request
Apr 17, 2026
Addresses all actionable evaluation warnings surfaced by #457. ## Changes | File | Warning fixed | |---|---| | `modules/home/editor.nix` | `programs.neovim.withRuby` and `programs.neovim.withPython3` — explicitly adopt new defaults (`false`) | | `modules/home/gpg.nix` | `programs.git.signing.format` — explicitly set to `"openpgp"` to preserve GPG signing on Rhizome | | `modules/home/scm.nix` | `programs.git.signing.format` — set `mkDefault null` as base so hosts without GPG adopt the new default silently | | `modules/home/development.nix` | `programs.claude-code.memory.source` → `programs.claude-code.context` | | `hosts/glyph/home.nix` | `programs.opencode.rules` → `programs.opencode.context` | | `hosts/zeta/hardware.nix` | `linux-rpi series` deprecation — removed explicit `linux_rpi4` kernel package; `nixos-hardware.nixosModules.raspberry-pi-4` (already imported) handles the kernel | ## Not fixed One warning remains on glyph: `'system' has been renamed to/replaced by 'stdenv.hostPlatform.system'`. This originates from the `attic` flake (a transitive dependency via `services.atticd`), not from this repo's code. It requires an upstream fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture stderr from
nix evalduring the CI eval job and emit GitHub Actions warning annotations when evaluation warnings are detected. The step also fails so thebuildjob is blocked, making warnings impossible to miss on PRs.Closes #274
What changed
eval_hostfunctionevaluation warning:in stderr triggers a::warning::annotation (visible in the PR checks summary) and fails the step%0Aso the full text appears in the annotationVerify
Check that a config with an evaluation warning causes the eval job to fail and shows the warning text as an annotation on the PR.