graphql: emit wire request + raw response under --http.log.enabled; fix typos#104
Merged
Merged
Conversation
…ix typos Closes #103. The GraphQL acquire path's --http.log.enabled output only surfaced the post-transform projection, hiding the rendered query string and the naked pre-transform response. Both are essential for diagnosing template-rendering and response-transform failures. Add an exported ContextWithHTTPLogger(ctx, io.Writer) so callers (stackql) can attach the same writer they hand to the REST acquire path when runtimeCtx.HTTPLogEnabled is true. Read() now emits the wire URL + request body before Do(), and the raw response bytes before json.Decode — matching the REST line format so existing log tooling keeps working. With no logger in the context, behaviour is byte-identical to today. Also fix two long-standing typos in the same Read() function's error messages: "accomodate" -> "accommodate" and "pocessed" -> "processed". A package-wide grep for the typo set listed in the issue surfaced only these two sites. Co-authored-by: Jeffrey Aven <jeffreyaven@users.noreply.github.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
general-kroll-4-life
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #103.
The GraphQL acquire path's --http.log.enabled output only surfaced the post-transform projection, hiding the rendered query string and the naked pre-transform response. Both are essential for diagnosing template-rendering and response-transform failures.
Add an exported ContextWithHTTPLogger(ctx, io.Writer) so callers (stackql) can attach the same writer they hand to the REST acquire path when runtimeCtx.HTTPLogEnabled is true. Read() now emits the wire URL + request body before Do(), and the raw response bytes before json.Decode — matching the REST line format so existing log tooling keeps working. With no logger in the context, behaviour is byte-identical to today.
Also fix two long-standing typos in the same Read() function's error messages: "accomodate" -> "accommodate" and "pocessed" -> "processed". A package-wide grep for the typo set listed in the issue surfaced only these two sites.