Replace Google Compute instance tests with stable GCS bucket resource#26
Merged
jeffreyaven merged 3 commits intomainfrom Mar 15, 2026
Merged
Conversation
Switch all Google test references from google.compute.instances (stackql-integration-tests project, australia-southeast1-a zone) to google.storage.buckets (stackql project, stackql-public-releases bucket). Bucket properties (name, location, locationType) are stable and not subject to instance lifecycle costs. Remove GOOGLE_ZONE variable dependency throughout. https://claude.ai/code/session_019CH6RrcMGtdUafvyVCKCHE
stackql serialises JSON keys alphabetically, so expected result strings must use the same order (location, locationType, name) to pass deep equality checks. https://claude.ai/code/session_019CH6RrcMGtdUafvyVCKCHE
assert.js: replace JSON.stringify deep equality with key-sorted comparison so JSON objects match regardless of key order. stackql-assert-test.yml: hardcode GOOGLE_PROJECT=stackql in the inline jsonnet test vars instead of pulling from the repo variable (which still pointed at stackql-integration-tests). https://claude.ai/code/session_019CH6RrcMGtdUafvyVCKCHE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch all Google test references from google.compute.instances (stackql-integration-tests project, australia-southeast1-a zone) to google.storage.buckets (stackql project, stackql-public-releases bucket). Bucket properties (name, location, locationType) are stable and not subject to instance lifecycle costs. Remove GOOGLE_ZONE variable dependency throughout.
https://claude.ai/code/session_019CH6RrcMGtdUafvyVCKCHE