Skip to content

Claude/fix window function execution 01 wb dt4 a6k m pz l5 k jm lwahbu #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffreyaven merged 3 commits into from
Dec 1, 2025
Merged

Claude/fix window function execution 01 wb dt4 a6k m pz l5 k jm lwahbu #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1615712
fix: output OVER clause in rewritten SQL for window functions
claude Dec 1, 2025
5b9e1aa
fix: use astformat.String for multi-arg functions to preserve OVER cl…
claude Dec 1, 2025
e755b7a
fix: only use astformat.String for window functions with OVER clause
claude Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/stackql/astvisit/fragment_rewriting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,6 +905,9 @@ func (v *standardFragmentRewriteAstVisitor) Visit(node sqlparser.SQLNode) error
buf.WriteString(funcName)
}
buf.AstPrintf(node, "(%s%v)", distinct, node.Exprs)
if node.Over != nil {
buf.AstPrintf(node, " %v", node.Over)
}
v.rewrittenQuery = buf.String()

case *sqlparser.GroupConcatExpr:
Expand Down
3 changes: 3 additions & 0 deletions internal/stackql/astvisit/from_rewrite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,6 +975,9 @@ func (v *standardFromRewriteAstVisitor) Visit(node sqlparser.SQLNode) error {
buf.WriteString(funcName)
}
buf.AstPrintf(node, "(%s%v)", distinct, node.Exprs)
if node.Over != nil {
buf.AstPrintf(node, " %v", node.Over)
}
v.rewrittenQuery = buf.String()

case *sqlparser.GroupConcatExpr:
Expand Down
3 changes: 3 additions & 0 deletions internal/stackql/astvisit/provider_string_extract.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,6 +904,9 @@ func (v *standardProviderStringAstVisitor) Visit(node sqlparser.SQLNode) error {
buf.WriteString(funcName)
}
buf.AstPrintf(node, "(%s%v)", distinct, node.Exprs)
if node.Over != nil {
buf.AstPrintf(node, " %v", node.Over)
}
// v.rewrittenQuery = buf.String()

case *sqlparser.GroupConcatExpr:
Expand Down
9 changes: 8 additions & 1 deletion internal/stackql/parserutil/parser_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,14 @@ func inferColNameFromExpr(
exprsDecorated = append(exprsDecorated, rv.DecoratedColumn)
}
}
decoratedColumn := fmt.Sprintf("%s(%s)", funcNameLowered, strings.Join(exprsDecorated, ", "))
// Use astformat.String for window functions to include OVER clause,
// otherwise use the manually constructed decorated column for proper arg handling
var decoratedColumn string
if expr.Over != nil {
decoratedColumn = astformat.String(expr, formatter)
} else {
decoratedColumn = fmt.Sprintf("%s(%s)", funcNameLowered, strings.Join(exprsDecorated, ", "))
}
if retVal.Name != constants.SQLFuncJSONExtractPostgres {
retVal.DecoratedColumn = getDecoratedColRendition(decoratedColumn, alias)
}
Expand Down
Loading