feat: add CTE support and robot tests for window functions #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement CTE (Common Table Expression) support in execution layer - Extract CTEs from WITH clause during AST expansion - Convert CTE references to inline subqueries for processing - Store CTE registry in visitor for reference resolution - Add robot tests for window functions - ROW_NUMBER() OVER - SUM() OVER (with and without ORDER BY) - RANK() OVER - Add robot test for simple CTE usage - Test queries using WITH clause against accelerator types data
… complexity Move CTE reference handling into separate processCTEReference method to satisfy nestif linter complexity requirements.
- Remove unused error return from processCTEReference (unparam fix) - Extract visitAliasedTableExpr helper method to reduce nesting (nestif fix)
…olution The CTE implementation was storing an indirect but not modifying the original AST node. This caused GetHIDs to still see a TableName type instead of a Subquery type, resulting in "could not locate table" errors. Fix: Modify the original node.Expr to be the CTE's Subquery instead of creating a synthetic expression. This ensures downstream code correctly recognizes the CTE reference as a subquery. Also re-enables the CTE robot test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement CTE (Common Table Expression) support in execution layer
Add robot tests for window functions
Add robot test for simple CTE usage
Description
Type of change
Issues referenced.
Evidence
Checklist:
Variations
Tech Debt