Skip to content

fix: handle BinaryExpr and propagate aggregate status in complex expr… #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffreyaven merged 1 commit into from
Dec 2, 2025
Merged

fix: handle BinaryExpr and propagate aggregate status in complex expr… #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions internal/stackql/parserutil/parser_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,10 @@ func inferColNameFromExpr(
rv.DecoratedColumn = fmt.Sprintf(`%s%s`, rv.DecoratedColumn, constants.PostgresJSONCastSuffix)
}
}
// Propagate aggregate status from arguments
if rv.IsAggregateExpr {
retVal.IsAggregateExpr = true
}
exprsDecorated = append(exprsDecorated, rv.DecoratedColumn)
}
}
Expand Down Expand Up @@ -799,6 +803,23 @@ func inferColNameFromExpr(
return retVal, nil
}
}
case *sqlparser.BinaryExpr:
// Binary expressions (arithmetic, etc.) are computed expressions
decoratedColumn := astformat.String(expr, formatter)
retVal.DecoratedColumn = getDecoratedColRendition(decoratedColumn, alias)
// Check if either operand contains aggregate/window functions
lhsRetval, _ := inferColNameFromExpr(expr.Left, formatter, "")
rhsRetval, _ := inferColNameFromExpr(expr.Right, formatter, "")
// If either side is an aggregate expression, the whole binary expr is computed
if lhsRetval.IsAggregateExpr || rhsRetval.IsAggregateExpr {
retVal.IsAggregateExpr = true
}
// Try to get a name from either operand for reference
if lhsRetval.Name != "" {
retVal.Name = lhsRetval.Name
} else if rhsRetval.Name != "" {
retVal.Name = rhsRetval.Name
}
default:
decoratedColumn := astformat.String(expr, formatter)
retVal.DecoratedColumn = getDecoratedColRendition(decoratedColumn, alias)
Expand Down
Loading