Skip to content

[pull] v4-dev from twbs:v4-dev #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Dec 6, 2018
Merged

[pull] v4-dev from twbs:v4-dev #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/tests/unit/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"extends": "../../../.eslintrc.json",
"rules": {
"no-console": "off",
"no-console": "error",
// Best Practices
"consistent-return": "off",
"no-magic-numbers": "off",
Expand Down
1 change: 0 additions & 1 deletion js/tests/unit/tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,6 @@ $(function () {
$tooltip.bootstrapTooltip('show')
} catch (err) {
passed = false
console.log(err)
}

assert.ok(passed, '.tooltip(\'show\') should not throw an error if element no longer is in dom')
Expand Down
1 change: 0 additions & 1 deletion js/tests/unit/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ $(function () {
var shadowRoot = $div[0].attachShadow({
mode: 'open'
})
console.warn($div[0].attachShadow, shadowRoot)

assert.equal(shadowRoot, Util.findShadowRoot(shadowRoot))
shadowRoot.innerHTML = '<button>Shadow Button</button>'
Expand Down