Skip to content

Add pre-commit target for faster runs locally#1100

Merged
SimonBaeumer merged 2 commits intomainfrom
sb/add-pre-commit-target
Jun 16, 2023
Merged

Add pre-commit target for faster runs locally#1100
SimonBaeumer merged 2 commits intomainfrom
sb/add-pre-commit-target

Conversation

@SimonBaeumer
Copy link
Copy Markdown
Contributor

Description

My pre-commit runs sometimes take a lot of time. It seems that on my machine they are often executed against all files.
I didn't figured out how to fix this, instead added a workaround as a Makefile target.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

  • Run make pre-commit

@SimonBaeumer SimonBaeumer requested a review from dhaus67 June 15, 2023 08:16
@SimonBaeumer SimonBaeumer temporarily deployed to development June 15, 2023 08:16 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development June 15, 2023 08:16 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development June 15, 2023 08:16 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development June 16, 2023 09:03 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development June 16, 2023 09:03 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development June 16, 2023 09:03 — with GitHub Actions Inactive
@SimonBaeumer
Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kurlov, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [SimonBaeumer,kurlov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SimonBaeumer SimonBaeumer merged commit 3569dac into main Jun 16, 2023
@SimonBaeumer SimonBaeumer deleted the sb/add-pre-commit-target branch June 16, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants