Skip to content

Tweak probe log to show central ID on create#1120

Merged
mtodor merged 1 commit intomainfrom
mtodor/tweak-probe-log-to-show-central-id
Jun 22, 2023
Merged

Tweak probe log to show central ID on create#1120
mtodor merged 1 commit intomainfrom
mtodor/tweak-probe-log-to-show-central-id

Conversation

@mtodor
Copy link
Copy Markdown
Contributor

@mtodor mtodor commented Jun 22, 2023

Description

During the release process, it would be helpful to see which central is created by probe.

This can be helpful for a few reasons:

  1. when we update ACS operator and all ACS instances are paused for reconciliation. A new instance would still be created with a new version of the operator and it would be helpful to see the ID of the instance created by probe, so that we can make a closer look at used images in generated resources and see if it is really using a new version
  2. sometimes, during release, when we are rolling out updates for ACS instances and there are several restarts we can see a lot of alerts in a pending state, but we are not sure if that is a probe instance or not. By looking at the log what was created by probe we could easy ignore related namespace and identify if there are really problems with existing instances

Checklist (Definition of Done)

  • [ ] Unit and integration tests added
  • [ ] Added test description under Test manual
  • [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • [ ] Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • [ ] Add secret to app-interface Vault or Secrets Manager if necessary
  • [ ] RDS changes were e2e tested manually
  • [ ] Check AWS limits are reasonable for changes provisioning new resources

@mtodor mtodor requested a review from stehessel June 22, 2023 11:39
@mtodor mtodor temporarily deployed to development June 22, 2023 11:39 — with GitHub Actions Inactive
@mtodor mtodor temporarily deployed to development June 22, 2023 11:39 — with GitHub Actions Inactive
@mtodor mtodor temporarily deployed to development June 22, 2023 11:39 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

@stehessel stehessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just adding some more ways to check for probe instances in case you didn't know:

  • You can filter by central.Owner = rhacs-probe via a GABI query to request all current and past probe instances.
  • In prometheus metrics and alerts, you can take a look at the rhacs_org_name/rhacs_org_id=16536854 labels to identify the probe.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtodor, stehessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtodor mtodor merged commit f661bf2 into main Jun 22, 2023
@mtodor mtodor deleted the mtodor/tweak-probe-log-to-show-central-id branch June 22, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants