Tweak probe log to show central ID on create#1120
Merged
Conversation
stehessel
approved these changes
Jun 22, 2023
Contributor
There was a problem hiding this comment.
LGTM. Just adding some more ways to check for probe instances in case you didn't know:
- You can filter by
central.Owner = rhacs-probevia a GABI query to request all current and past probe instances. - In prometheus metrics and alerts, you can take a look at the
rhacs_org_name/rhacs_org_id=16536854labels to identify the probe.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtodor, stehessel The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During the release process, it would be helpful to see which central is created by probe.
This can be helpful for a few reasons:
Checklist (Definition of Done)
[ ] Unit and integration tests added[ ] Added test description underTest manual[ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)[ ] Add the ticket number to the PR title if available, i.e.ROX-12345: ...[ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.[ ] Add secret to app-interface Vault or Secrets Manager if necessary[ ] RDS changes were e2e tested manually[ ] Check AWS limits are reasonable for changes provisioning new resources