Skip to content

ROX-27234: Cleanup gh acs-fleetshard-operator build#2114

Merged
kurlov merged 2 commits intomainfrom
akurlov/ROX-27234-cleanup-previous-acs-fleetshard-operator-build-gh
Dec 5, 2024
Merged

ROX-27234: Cleanup gh acs-fleetshard-operator build#2114
kurlov merged 2 commits intomainfrom
akurlov/ROX-27234-cleanup-previous-acs-fleetshard-operator-build-gh

Conversation

@kurlov
Copy link
Copy Markdown
Member

@kurlov kurlov commented Dec 3, 2024

Description

Cleanup unused build

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

N/A

@kurlov kurlov requested a review from kovayur December 3, 2024 18:11
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurlov kurlov merged commit d760158 into main Dec 5, 2024
@kurlov kurlov deleted the akurlov/ROX-27234-cleanup-previous-acs-fleetshard-operator-build-gh branch December 5, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants