Skip to content

Delete DOCKER_CONFIG and INHERIT_IMAGEPULLSECRETS from dev/e2e test scripts#2168

Merged
kovayur merged 10 commits intomainfrom
yury/delete-docker-config
Feb 5, 2025
Merged

Delete DOCKER_CONFIG and INHERIT_IMAGEPULLSECRETS from dev/e2e test scripts#2168
kovayur merged 10 commits intomainfrom
yury/delete-docker-config

Conversation

@kovayur
Copy link
Copy Markdown
Contributor

@kovayur kovayur commented Jan 27, 2025

Description

  • Remove DOCKER_CONFIG since it is not used anymore and brings confusion
  • Remove INHERIT_IMAGEPULLSECRETS since it's always tru
  • Eliminate the QUAY_USER and QUAY_TOKEN requirement using a more advanced script copied from stackrox.
  • Refactor create-imagepullsecrets
  • Merge redhat-pull-secret.sh into create-imagepullsecrets. Add fallback to docker-auth when ocm returns error (auth failures when using short-lived tokens).

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kovayur
Copy link
Copy Markdown
Contributor Author

kovayur commented Jan 31, 2025

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit 2285fc0 into main Feb 5, 2025
14 checks passed
@kovayur kovayur deleted the yury/delete-docker-config branch February 5, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants