Skip to content

ROX-13092: Add openshift eventrouter to persist kubernetes events to CloudWatch#911

Merged
rhybrillou merged 2 commits intomainfrom
yann/ROX-13092-openshift_eventrouter
Apr 13, 2023
Merged

ROX-13092: Add openshift eventrouter to persist kubernetes events to CloudWatch#911
rhybrillou merged 2 commits intomainfrom
yann/ROX-13092-openshift_eventrouter

Conversation

@rhybrillou
Copy link
Copy Markdown
Contributor

@rhybrillou rhybrillou commented Mar 30, 2023

Description

The goal here is to persist kubernetes events to cloudwatch in order to ease later troubleshooting of issues.
This relies on the openshift eventrouter component.

Checklist (Definition of Done)

- [ ] Unit and integration tests added

  • Added test description under Test manual
    - [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 30, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhybrillou rhybrillou temporarily deployed to development March 30, 2023 12:32 — with GitHub Actions Inactive
@rhybrillou
Copy link
Copy Markdown
Contributor Author

/test all

@rhybrillou rhybrillou requested a review from a team March 31, 2023 16:27
@rhybrillou rhybrillou marked this pull request as ready for review March 31, 2023 16:27
@rhybrillou rhybrillou temporarily deployed to development March 31, 2023 16:27 — with GitHub Actions Inactive
@@ -0,0 +1,39 @@
apiVersion: apps/v1
kind: Deploy,ent
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kind: Deploy,ent
kind: Deployment

requests:
cpu: "100m"
memory: "128Mi"
volumeMounts:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some inconsistent indentation. Maybe you can run a formatter like prettier to make it consistent?

@rhybrillou rhybrillou temporarily deployed to development April 11, 2023 09:51 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development April 11, 2023 09:51 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development April 11, 2023 09:51 — with GitHub Actions Inactive
@rhybrillou rhybrillou requested a review from stehessel April 12, 2023 10:01
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhybrillou, stehessel
Once this PR has been reviewed and has the lgtm label, please assign ivan-degtiarenko for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhybrillou rhybrillou merged commit c2229e0 into main Apr 13, 2023
@rhybrillou rhybrillou deleted the yann/ROX-13092-openshift_eventrouter branch April 13, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants