Skip to content

Add missing AWS_ROLE_ARN parameter in dev script for fleetshard-sync#916

Merged
kovayur merged 2 commits intomainfrom
yury/fix-loading-aws-role-arn-in-dev
Apr 4, 2023
Merged

Add missing AWS_ROLE_ARN parameter in dev script for fleetshard-sync#916
kovayur merged 2 commits intomainfrom
yury/fix-loading-aws-role-arn-in-dev

Conversation

@kovayur
Copy link
Copy Markdown
Contributor

@kovayur kovayur commented Apr 3, 2023

Description

This PR adds loading of AWS_ROLE_ARN in dev scripts.
AWS_ROLE_ARN stays in Parameter Store for now, which makes it unavailable from the dev scripts, because they are loading the configuration from Secrets Manager only.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@kovayur kovayur requested a review from vladbologa April 3, 2023 14:03
@kovayur kovayur temporarily deployed to development April 3, 2023 14:03 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot added the approved label Apr 3, 2023
@kovayur kovayur force-pushed the yury/fix-loading-aws-role-arn-in-dev branch from 3d5ceec to 5226dff Compare April 3, 2023 14:04
@kovayur kovayur temporarily deployed to development April 3, 2023 14:04 — with GitHub Actions Inactive
@kovayur kovayur requested a review from porridge April 4, 2023 08:36
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, porridge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur enabled auto-merge (squash) April 4, 2023 08:46
@openshift-ci openshift-ci bot removed the lgtm label Apr 4, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 4, 2023

New changes are detected. LGTM label has been removed.

@kovayur kovayur temporarily deployed to development April 4, 2023 09:08 — with GitHub Actions Inactive
@kovayur kovayur merged commit e4816ce into main Apr 4, 2023
@kovayur kovayur deleted the yury/fix-loading-aws-role-arn-in-dev branch April 4, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants