ROX-14030: use new availability SLI rules in dashboard#949
Merged
Conversation
kurlov
reviewed
Apr 13, 2023
| { | ||
| "current": { | ||
| "selected": true, | ||
| "selected": false, |
Contributor
Author
There was a problem hiding this comment.
I didn't disable it on purpose, the dashboard selects it by default. You have to click on it again for it to show up as selected in the json output.
| "title": "ACS Fleet Manager SLOs", | ||
| "uid": "T2kek3H9a", | ||
| "version": 21, | ||
| "version": 1, |
Contributor
Author
There was a problem hiding this comment.
What's the purpose of these versions? I thought they are only relevant to dashboards saved within Grafana - which we don't do, for us the git repo is the state of truth.
dhaus67
approved these changes
Apr 13, 2023
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaus67, stehessel The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the newly introduced availability SLI recording rules (see https://gitlab.cee.redhat.com/service/app-interface/-/merge_requests/62734) in the SLO dashboard. In particular, the availability SLO now incorporate the K8s pod ready status.