Conversation
f8fcf77 to
e83b255
Compare
dhaus67
left a comment
There was a problem hiding this comment.
While we're at it, in the past when dealing with failing probe runs, the error messages for e.g. creation request failing where something along the lines of:
central creation failed: 403 forbidden
It would make initial triaging a lot faster when we could also print the error message within the logs contained within the http.Response we receive. OK for me to do this in a follow-up PR (I'm also open to change this if you don't feel like it right now since we are all relying on the probe service one way or another :) ).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaus67, stehessel The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'd appreciate that, thanks :) |
Description
Small improvement of the probe logging:
Checklist (Definition of Done)
Unit and integration tests addedAdded test description underTest manualDocumentation added if necessary (i.e. changes to dev setup, test execution, ...)Add the ticket number to the PR title if available, i.e.ROX-12345: ...Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.