Skip to content

Error message fix, take 100#988

Merged
SimonBaeumer merged 1 commit intomainfrom
sb/legendary-error-message-review
Apr 26, 2023
Merged

Error message fix, take 100#988
SimonBaeumer merged 1 commit intomainfrom
sb/legendary-error-message-review

Conversation

@SimonBaeumer
Copy link
Copy Markdown
Contributor

Description

Error message fix, take 100

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 26, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@SimonBaeumer SimonBaeumer temporarily deployed to development April 26, 2023 08:40 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development April 26, 2023 08:40 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer requested a review from ludydoo April 26, 2023 08:40
@SimonBaeumer SimonBaeumer temporarily deployed to development April 26, 2023 08:40 — with GitHub Actions Inactive
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ludydoo, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SimonBaeumer SimonBaeumer marked this pull request as ready for review April 26, 2023 08:49
@SimonBaeumer SimonBaeumer temporarily deployed to development April 26, 2023 08:50 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development April 26, 2023 08:50 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer temporarily deployed to development April 26, 2023 08:50 — with GitHub Actions Inactive
@SimonBaeumer SimonBaeumer enabled auto-merge (squash) April 26, 2023 08:52
@SimonBaeumer SimonBaeumer merged commit 70c099e into main Apr 26, 2023
@SimonBaeumer SimonBaeumer deleted the sb/legendary-error-message-review branch April 26, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants