Skip to content

ROX-16791: Increase route timeout to 10m to allow for longer operations#996

Merged
connorgorman merged 3 commits intomainfrom
cgorman-extend-timeout
May 4, 2023
Merged

ROX-16791: Increase route timeout to 10m to allow for longer operations#996
connorgorman merged 3 commits intomainfrom
cgorman-extend-timeout

Conversation

@connorgorman
Copy link
Copy Markdown
Contributor

@connorgorman connorgorman commented Apr 27, 2023

Description

https://issues.redhat.com/browse/ROX-16791

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary

Test manual

Manually edited the route in staging

time curl 'https://<url>/api/graphql?opname=triggerScan' --data-raw $'{"operationName":"triggerScan","variables":{"clusterId":"*","standardId":"*"},"query":"mutation triggerScan($clusterId: ID\u0021, $standardId: ID\u0021) {\\n  complianceTriggerRuns(clusterId: $clusterId, standardId: $standardId) {\\n    id\\n    standardId\\n    clusterId\\n    state\\n    errorMessage\\n    __typename\\n  }\\n}\\n"}'   --compressed

real	5m56.838s
user	0m0.019s
sys	0m0.018s

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@connorgorman connorgorman requested a review from kovayur April 27, 2023 18:59
@connorgorman connorgorman temporarily deployed to development April 27, 2023 18:59 — with GitHub Actions Inactive
@connorgorman connorgorman temporarily deployed to development April 27, 2023 18:59 — with GitHub Actions Inactive
@connorgorman connorgorman temporarily deployed to development April 27, 2023 18:59 — with GitHub Actions Inactive
@connorgorman connorgorman temporarily deployed to development April 27, 2023 19:03 — with GitHub Actions Inactive
@connorgorman connorgorman temporarily deployed to development April 27, 2023 19:03 — with GitHub Actions Inactive
@connorgorman connorgorman temporarily deployed to development April 27, 2023 19:03 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot removed the lgtm label Apr 28, 2023
@connorgorman connorgorman temporarily deployed to development April 28, 2023 19:34 — with GitHub Actions Inactive
@connorgorman connorgorman temporarily deployed to development April 28, 2023 19:34 — with GitHub Actions Inactive
@connorgorman connorgorman temporarily deployed to development April 28, 2023 19:34 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot added the lgtm label May 1, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: connorgorman, kylape
Once this PR has been reviewed and has the lgtm label, please assign ivan-degtiarenko for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connorgorman connorgorman merged commit b27ede3 into main May 4, 2023
@connorgorman connorgorman deleted the cgorman-extend-timeout branch May 4, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants