fix: don't fail integration test jobs on artifact upload errors#3296
Merged
fix: don't fail integration test jobs on artifact upload errors#3296
Conversation
The Store artifacts step uploads debug logs for human inspection but is not consumed by any downstream job. Network errors (ECONNRESET) during upload were causing passing test runs to be marked as failed — 9 false positives in the last week alone. Test failures still fail the job via the Run Tests step.
Molter73
approved these changes
Apr 29, 2026
Collaborator
Molter73
left a comment
Molter73
left a comment
There was a problem hiding this comment.
LGTM!
Could you make this same change in stackrox/fact? I've seen this same problem a bunch but have not had time to look into it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3296 +/- ##
==========================================
- Coverage 27.38% 27.31% -0.07%
==========================================
Files 95 95
Lines 5427 5425 -2
Branches 2548 2548
==========================================
- Hits 1486 1482 -4
- Misses 3214 3216 +2
Partials 727 727
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced May 5, 2026
Merged
Stringy
added a commit
that referenced
this pull request
May 6, 2026
… (#3326) The Store artifacts step uploads debug logs for human inspection but is not consumed by any downstream job. Network errors (ECONNRESET) during upload were causing passing test runs to be marked as failed — 9 false positives in the last week alone. Test failures still fail the job via the Run Tests step.
Stringy
added a commit
that referenced
this pull request
May 6, 2026
… (#3327) The Store artifacts step uploads debug logs for human inspection but is not consumed by any downstream job. Network errors (ECONNRESET) during upload were causing passing test runs to be marked as failed — 9 false positives in the last week alone. Test failures still fail the job via the Run Tests step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Store artifacts step uploads debug logs for human inspection but is not consumed by any downstream job. Network errors (ECONNRESET) during upload were causing passing test runs to be marked as failed — 9 false positives in the last week alone.
Test failures still fail the job via the Run Tests step.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Trivial CI fix.