ROX-30259: Add a basic integration test framework#1
Merged
Conversation
ca1b341 to
930ee4b
Compare
Contributor
|
So ... you are doing fact checking ? 🥁 |
Contributor
Author
Stringy
reviewed
Aug 6, 2025
The tests are based on pytest, since it should be the easiest way to get them to run on as many systems as possible natively. The only test that has been implemented is incredibly simple and naive, just create a new directory, run fact monitoring said directory create a file in there and expect an event from fact in a gRPC server. In order to work around a verifier issue, path filtering has been moved from the kernel to userspace, this is not ideal and we might need to come back and fix it sometime in the future. Next step will be to flesh out the tests and integrate them with the collector ansible scripts to run them on GCP.
c17b400 to
b11f74c
Compare
Stringy
approved these changes
Aug 11, 2025
* test: Add basis to run integration tests on GCP * Run integration tests on GCP * Generate logs and test results and upload them as artifacts * Add error to test for checking handling of errors on CI * Revert "Add error to test for checking handling of errors on CI" This reverts commit 0d99ef6. * Simplify constants.mk and minor cleanup * Rename logs fixture to logs_dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
The tests are based on pytest, since it should be the easiest way to get them to run on as many systems as possible natively. The only test that has been implemented is incredibly simple and naive, just create a new directory, run fact monitoring said directory create a file in there and expect an event from fact in a gRPC server.
In order to work around a verifier issue, path filtering has been moved from the kernel to userspace, this is not ideal and we might need to come back and fix it sometime in the future.
Next step will be to flesh out the tests and integrate them with the collector ansible scripts to run them on GCP.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Run the tests locally on a Fedora 42 machine and pass: