Skip to content

ROX-28137: implement Janitor flavors hidden from users#1534

Merged
tommartensen merged 54 commits into
masterfrom
tm/infra-janitor-h1
Apr 1, 2025
Merged

ROX-28137: implement Janitor flavors hidden from users#1534
tommartensen merged 54 commits into
masterfrom
tm/infra-janitor-h1

Conversation

@tommartensen

@tommartensen tommartensen commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

Test it with infractl create janitor-delete-{gke-default, openshift-4, openshift-rosa} <cluster name>.

Prevents flavors with janitorDelete availability to show up on

  • UI
  • infractl flavor list
  • infractl flavor get

Related: https://github.com/stackrox/automation-flavors/pull/310/files for fixes/improvements to the destroy functions.

Base automatically changed from tm/destroy-flavors to tm/improve-test-performance March 21, 2025 15:34
@rhacs-bot

rhacs-bot commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

A single node development cluster (infra-pr-1534) was allocated in production infra for this PR.

CI will attempt to deploy quay.io/rhacs-eng/infra-server:0.11.13-54-g3e5fa49988 to it.

🔌 You can connect to this cluster with:

gcloud container clusters get-credentials infra-pr-1534 --zone us-central1-a --project acs-team-temp-dev

🛠️ And pull infractl from the deployed dev infra-server with:

nohup kubectl -n infra port-forward svc/infra-server-service 8443:8443 &
make pull-infractl-from-dev-server

🚲 You can then use the dev infra instance e.g.:

bin/infractl -k -e localhost:8443 whoami

⚠️ Any clusters that you start using your dev infra instance should have a lifespan shorter then the development cluster instance. Otherwise they will not be destroyed when the dev infra instance ceases to exist when the development cluster is deleted. ⚠️

Further Development

☕ If you make changes, you can commit and push and CI will take care of updating the development cluster.

🚀 If you only modify configuration (chart/infra-server/configuration) or templates (chart/infra-server/{static,templates}), you can get a faster update with:

make helm-deploy

Logs

Logs for the development infra depending on your @redhat.com authuser:

Or:

kubectl -n infra logs -l app=infra-server --tail=1 -f

@tommartensen tommartensen self-assigned this Mar 21, 2025
Base automatically changed from tm/improve-test-performance to master March 25, 2025 11:00
@tommartensen tommartensen changed the title WIP: Janitor (horizon 1) ROX-28137: implement Janitor flavors hidden from users Apr 1, 2025
@tommartensen tommartensen marked this pull request as ready for review April 1, 2025 08:04
@tommartensen tommartensen requested a review from a team as a code owner April 1, 2025 08:04
@tommartensen tommartensen enabled auto-merge (squash) April 1, 2025 09:25

@davdhacs davdhacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
This is great! And I think the concept of argo workflows matches well with ad-hoc 'janitor' cluster cleanup.

@tommartensen tommartensen merged commit 1c3bd4b into master Apr 1, 2025
@tommartensen tommartensen deleted the tm/infra-janitor-h1 branch April 1, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants