Skip to content

Don't hard-code temporaryfilename for CA certificate#114

Merged
mclasmeier merged 9 commits into
mainfrom
mc/roxie-ca-cert-setup
Apr 28, 2026
Merged

Don't hard-code temporaryfilename for CA certificate#114
mclasmeier merged 9 commits into
mainfrom
mc/roxie-ca-cert-setup

Conversation

@mclasmeier
Copy link
Copy Markdown
Collaborator

@mclasmeier mclasmeier commented Apr 27, 2026

Part of #91.

This PR also fixes a bug (same bug in multiple lines), where we are doing

env = append(env, fmt.Sprintf("ROX_ENDPOINT=%q", endpoint))

instead of

env = append(env, fmt.Sprintf("ROX_ENDPOINT=%s", endpoint))

resulting in literal quotation characters ending up in the variable values.

Comment thread internal/deployer/deploy_via_operator.go Outdated
@mclasmeier mclasmeier requested a review from vladbologa April 27, 2026 14:50
@AlexVulaj
Copy link
Copy Markdown
Contributor

One thing I noticed — cmd/teardown.go also calls deployer.New() (line 43) but doesn't have the deferred Cleanup() that you added to cmd/deploy.go. Might want to add it there too so teardowns don't leak temp dirs.

Comment thread cmd/subshell.go
Comment thread cmd/deploy.go Outdated
Comment thread cmd/teardown.go Outdated
Comment thread internal/deployer/deployer.go Outdated
@mclasmeier mclasmeier merged commit 6a3ba8f into main Apr 28, 2026
3 checks passed
@mclasmeier mclasmeier deleted the mc/roxie-ca-cert-setup branch May 18, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants