Run e2e tests in CI#116
Merged
Merged
Conversation
added 7 commits
April 28, 2026 10:08
…hich take pretty long (for now, will be revisited for decent coverage)
mclasmeier
requested review from
AlexVulaj,
porridge,
tommartensen and
vladbologa
porridge
approved these changes
Apr 28, 2026
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Contributor
|
Still LGTM modulo the cluster name reuse question. |
Collaborator
Author
Cool. Let's wait for @tommartensen to chime in on the remaining cluster reuse question. |
AlexVulaj
reviewed
Apr 29, 2026
AlexVulaj
reviewed
Apr 29, 2026
AlexVulaj
reviewed
Apr 29, 2026
Collaborator
Author
|
@AlexVulaj Hope I have addresses everything. |
AlexVulaj
reviewed
Apr 30, 2026
AlexVulaj
reviewed
Apr 30, 2026
AlexVulaj
reviewed
Apr 30, 2026
Co-authored-by: Alex Vulaj <ajvulaj@gmail.com>
Co-authored-by: Alex Vulaj <ajvulaj@gmail.com>
AlexVulaj
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables execution of (a subset of) the e2e tests in CI on PRs.
Why a subset? Because the e2e test suite in its current form needs to be revisited so that we maintain decent execution durations. We also need to consider which tests specifically make sense. Most of the current tests come from AI. This PR is to be considered as the foundation on which we will improve the test suite. See "Ouf of scope" below.
Reviewing notes
Most of the changes (line-wise) are refactoring: Moving helper functions for e2e tests into a dedicated file.
Issues
Related to
#75
#27
#117
Out of scope of this PR
Bringing the current e2e test suite into the best shape.
This PR is about:
Thanks to @tommartensen for the help.