Associate some TODOs with ROX-34499#122
Merged
Merged
Conversation
This is my attempt at prioritizing the existing TODO(#91) in the sense that those which are now associated with ROX-34499 should be resolved before roxie is used in CI. While the others are explicitly not blocking CI rollout of roxie.
porridge
approved these changes
Apr 30, 2026
Contributor
porridge
left a comment
porridge
left a comment
There was a problem hiding this comment.
LTGM.
Maybe this should also go in, up to you tests/e2e/e2e_test.go: // TODO(#91): this is a bit old...
Collaborator
Author
Oh, I think I have that in my pipeline already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt at prioritizing the existing TODO(#91) in the sense that those which are now associated with ROX-34499 should be resolved before roxie is used in CI.
While the others are explicitly not blocking CI rollout of roxie.