Skip to content

More robust OLM deployment check#133

Merged
mclasmeier merged 2 commits into
mainfrom
mc/olm-label-lookup
May 7, 2026
Merged

More robust OLM deployment check#133
mclasmeier merged 2 commits into
mainfrom
mc/olm-label-lookup

Conversation

@mclasmeier
Copy link
Copy Markdown
Collaborator

@mclasmeier mclasmeier commented May 4, 2026

Addresses another TODO: More robust checking of OLM labels indicating deployment of the operator via OLM.

Prerequisite for CI rollout.

Manual verification

Tested this against an GKE cluster + OLM installed, because infra OpenShift clusters currently don't spawn.

The operator deployment does have this label:

    olm.owner: rhacs-operator.v4.9.2

I then redeployed the operator with roxie with a different version:

roxie on  mc/olm-label-lookup [$?] via 🐹 v1.26.2 on ☁️  mclasmei@redhat.com took 4m55s 
❯ ./roxie deploy operator --olm -t 4.10.1
00:00 Using kubeconfig /Users/mclasmeier/.kube/infra/kubeconfig
00:00 Running with a controlling terminal.
00:01 🚀 ACS Deployer initialized
00:01 roxctl version: 4.11.x-725-gf948ae4b42
00:01 Using main image tag from --tag flag: 4.10.1
00:01 Preparing and verifying Docker credentials...
00:01 REGISTRY_USERNAME/REGISTRY_PASSWORD unset. Trying to obtain Docker credentials from config file: /Users/mclasmeier/.docker/config.json
00:02 Successfully verified credentials for quay.io (repository: rhacs-eng/main)
00:02 Docker credentials verified successfully
00:02 Initiating deployment of Operator
00:02 🚀 Deploying Operator only...
00:05 Operator version mismatch detected:
00:05   Current: 4.9.2
00:05   Desired: 4.10.1
00:05 🔄 Operator version mismatch, redeploying...
00:05 🧹 Tearing down operator deployed via OLM...
00:22   ⋯ Still waiting for namespace deletion... (11s elapsed)
00:32   ⋯ Still waiting for namespace deletion... (21s elapsed)
00:42   ⋯ Still waiting for namespace deletion... (31s elapsed)
00:52   ⋯ Still waiting for namespace deletion... (41s elapsed)
01:02   ⋯ Still waiting for namespace deletion... (51s elapsed)
01:13   ⋯ Still waiting for namespace deletion... (62s elapsed)
01:23   ⋯ Still waiting for namespace deletion... (72s elapsed)
01:25 Namespace rhacs-operator-system has been deleted
[...]

Notice the message

00:05 🧹 Tearing down operator deployed via OLM...

It correctly identified the current operator being deployed with OLM.

@mclasmeier mclasmeier added the ci-rollout Marks a PR to be a prerequisite for rolling out roxie in stackrox CI. label May 5, 2026
@mclasmeier mclasmeier marked this pull request as ready for review May 5, 2026 11:15
@mclasmeier mclasmeier requested a review from porridge May 5, 2026 11:16
Comment thread internal/deployer/operator_olm.go Outdated
@mclasmeier mclasmeier merged commit 597d792 into main May 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-rollout Marks a PR to be a prerequisite for rolling out roxie in stackrox CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants