More robust OLM deployment check#133
Merged
Merged
Conversation
porridge
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses another TODO: More robust checking of OLM labels indicating deployment of the operator via OLM.
Prerequisite for CI rollout.
Manual verification
Tested this against an GKE cluster + OLM installed, because infra OpenShift clusters currently don't spawn.
The operator deployment does have this label:
I then redeployed the operator with roxie with a different version:
Notice the message
It correctly identified the current operator being deployed with OLM.