Parse YAML for CRD identification#134
Merged
Merged
Conversation
mclasmeier
added
the
ci-rollout
AlexVulaj
reviewed
May 5, 2026
AlexVulaj
approved these changes
May 5, 2026
porridge
reviewed
May 7, 2026
| var meta struct { | ||
| Kind string `yaml:"kind"` | ||
| } | ||
| if err := yaml.Unmarshal(content, &meta); err != nil { |
Contributor
There was a problem hiding this comment.
Given that these files are sizes are rather large and that we only need a single string from them, would it make sense to use a streaming decoder that doesn't require allocating memory for the whole file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses another TODO, doing proper YAML unmarshaling for identifying CRDs in the operator bundle.
Prerequisite for CI rollout.
Manual verification
Deployed the operator with roxie and it shows
So it still finds the correct CRD files.