Explicitly list injected-cabundle config map for deletion#150
Merged
Conversation
vladbologa
approved these changes
May 7, 2026
Collaborator
vladbologa
left a comment
vladbologa
left a comment
There was a problem hiding this comment.
I'm thinking that this might still happen:
preventCABundleInjectionremoves the CNO labeldeleteResourcesdeletes everything- The explicit delete in the loop runs (no-op)
- CNO recreates the ConfigMap still
But it's fine also to merge and see if the race still happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To mitigate race with CNO. I have observed a failure on my system due to this.
#149