Differentiate between OpenShift4-on-infra and generic OpenShift4#155
Merged
Conversation
mclasmeier
added
the
ci-rollout
mclasmeier
added
the
olm-tests
porridge
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed that
--konfluxdoesn't work on OpenShift in Prow CI, because currently the cluster type for OpenShift only detects Infra OpenShift clusters, it does not identify the cluster provisioned by Prow CI as OpenShift.Why the distinction, why not get rid of the special-casing for
InfraOpenShift4? That distinction is still helpful, because infra-provisioned OpenShift4 clusters are configured in a way which allows us to short-circuit image pull credentials, which are not needed there. That is a UX feature.So, I have introduced another (generic) OpenShift4 cluster type.
Needed for CI rollout!