Skip to content

Simplify teardown, hopefully making it more robust against CNO races#164

Merged
mclasmeier merged 2 commits into
mainfrom
mc/simplify-teardown
May 11, 2026
Merged

Simplify teardown, hopefully making it more robust against CNO races#164
mclasmeier merged 2 commits into
mainfrom
mc/simplify-teardown

Conversation

@mclasmeier
Copy link
Copy Markdown
Collaborator

@mclasmeier mclasmeier commented May 10, 2026

See #146 (comment) for context.

I think the complexity this adds and the difficulties in getting this robust in the presence of multiple concurent processes (RHACS Operator/Helm reconciler, CNO operator, roxie teardown), is not really worth it.

@mclasmeier
Copy link
Copy Markdown
Collaborator Author

@vladbologa Your gut feeling was right -- the teardown was still susceptible to leaking of injected-cabundle configmap during teardown.

@mclasmeier mclasmeier changed the title Simply teardown, hopefully making it more robust against CNO races Simplify teardown, hopefully making it more robust against CNO races May 11, 2026
@mclasmeier mclasmeier requested a review from AlexVulaj May 11, 2026 14:28
Comment thread internal/deployer/deployer.go Outdated
@mclasmeier mclasmeier requested a review from AlexVulaj May 11, 2026 15:06
@mclasmeier
Copy link
Copy Markdown
Collaborator Author

🙏

@mclasmeier mclasmeier merged commit 2f6373e into main May 11, 2026
7 checks passed
@vladbologa
Copy link
Copy Markdown
Collaborator

@vladbologa Your gut feeling was right -- the teardown was still susceptible to leaking of injected-cabundle configmap during teardown.

Too late here, but I was thinking that maybe we could still have the old teardown behavior as a separate command, for the cases where the Operator teardown is broken? Something like --force-teardown

@mclasmeier mclasmeier deleted the mc/simplify-teardown branch May 18, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants