Support detached port forwarding#169
Merged
Merged
Conversation
Add StartDetached() to portforward.Manager that spawns kubectl port-forward in a new session (setsid) so it survives the parent process exiting. Returns the endpoint and PID for later cleanup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use detached port-forward in envrc mode so the kubectl port-forward process survives roxie exiting. The PID is written to the envrc file as ROXIE_PORT_FORWARD_PID for later cleanup. This removes the restrictions that prevented --envrc from being combined with --port-forwarding or --exposure=none, enabling roxie to work on kind clusters in non-interactive (CI) mode. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Stop passing --exposure=loadbalancer explicitly in e2e tests and rely on roxie's built-in cluster type detection to set the appropriate defaults (e.g. exposure=none + port-forwarding on kind, loadbalancer on GKE). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Read ROXIE_PORT_FORWARD_PID from the environment on deployer init and kill the process during teardownCentral, so the detached port-forward started in envrc mode doesn't leak. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
added 2 commits
May 11, 2026 21:13
Collaborator
Author
|
feel free to merge when CI is green. |
davdhacs
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.