Disable sub-shell spawning if running non-interactively#33
Merged
Conversation
mclasmeier
requested review from
davdhacs,
porridge,
tommartensen and
vladbologa
porridge
reviewed
Jan 13, 2026
porridge
approved these changes
Jan 19, 2026
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Collaborator
Author
|
There seems to be an unrelated issue with the docker building job, I will address this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preparation for #18.
--envrcto be specified). These are the two modes of executing the deployer: sub-shell spawning or envrc writing (containing passwords, endpoints, etc.).My proposal for issue #18 would be to disable the printing of confidential data (passwords, endpoints) if running non-interactively but keep it for convenience when running on a terminal.