Polish (containerized) roxie UX for OpenShift#49
Merged
Conversation
995ea0e to
da81f0d
Compare
da81f0d to
5f7d554
Compare
2ec2b36 to
efb9cea
Compare
efb9cea to
26734ed
Compare
Collaborator
Author
|
I got @kcarmichael08 to test out this version using the containerized workflow against an OpenShift cluster. Worked. 🎉 |
vladbologa
approved these changes
Mar 6, 2026
added 3 commits
March 9, 2026 09:33
…ng it from being run as part of the unit tests (which would fail with the new panicing behaviour)
Collaborator
Author
|
@vladbologa Addressed two comments, one is unclear to me. I had to touch one existing existing integration test, which would panic with the new behaviour when executed without valid kubectl context. |
vladbologa
approved these changes
Mar 9, 2026
vladbologa
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #39
User-facing:
:Usuffix for ownership changing is not provided). This change includes error messages specifically for the containerized workflow.Most of the changes are in the
internal/envpackage, specifically around the environment detection (cluster type detection). This has been reorganized to now require explicit initialization with aloggerinstead of implicit initialization on first use without any logger.This PR allows simplified one-command deployments to an Infra OpenShift clusters, e.g.:
Note that we are not passing
REGISTRY_USERNAMEandREGISTRY_PASSWORDanymore.