Skip to content

Polish (containerized) roxie UX for OpenShift#49

Merged
mclasmeier merged 10 commits into
mainfrom
mc/infra-ocp-no-ips
Mar 9, 2026
Merged

Polish (containerized) roxie UX for OpenShift#49
mclasmeier merged 10 commits into
mainfrom
mc/infra-ocp-no-ips

Conversation

@mclasmeier
Copy link
Copy Markdown
Collaborator

@mclasmeier mclasmeier commented Feb 11, 2026

Addresses #39

User-facing:

  • Don't require image pull credentials when deploying to Infra OpenShift (because they are already on the cluster). This applies to the non-containerized roxie as well.
  • Emit user-friendly messages in case something is wrong with the provided kubeconfig (e.g. in case the :U suffix for ownership changing is not provided). This change includes error messages specifically for the containerized workflow.

Most of the changes are in the internal/env package, specifically around the environment detection (cluster type detection). This has been reorganized to now require explicit initialization with a logger instead of implicit initialization on first use without any logger.

This PR allows simplified one-command deployments to an Infra OpenShift clusters, e.g.:

$ podman run --rm -it --privileged -v $KUBECONFIG:/kubeconfig:U \
  quay.io/rhacs-eng/roxie:0.1.0-20-g84b295b deploy -t 4.11.x-39-g9aeddf5917 --olm --resources=auto

Note that we are not passing REGISTRY_USERNAME and REGISTRY_PASSWORD anymore.

@mclasmeier mclasmeier force-pushed the mc/infra-ocp-no-ips branch 3 times, most recently from 995ea0e to da81f0d Compare February 11, 2026 14:11
@mclasmeier mclasmeier changed the title Testing Polish dockerized roxie experience (in particular for OpenShift) Feb 11, 2026
@mclasmeier mclasmeier changed the title Polish dockerized roxie experience (in particular for OpenShift) Polish containerized roxie experience (in particular for OpenShift) Feb 12, 2026
@mclasmeier mclasmeier changed the title Polish containerized roxie experience (in particular for OpenShift) Polish containerized roxie UX (in particular for OpenShift) Feb 12, 2026
@mclasmeier mclasmeier changed the title Polish containerized roxie UX (in particular for OpenShift) Polish containerized roxie UX for OpenShift Feb 17, 2026
@mclasmeier mclasmeier changed the title Polish containerized roxie UX for OpenShift Polish (containerized) roxie UX for OpenShift Feb 17, 2026
@mclasmeier
Copy link
Copy Markdown
Collaborator Author

I got @kcarmichael08 to test out this version using the containerized workflow against an OpenShift cluster. Worked. 🎉

Copy link
Copy Markdown
Collaborator

@vladbologa vladbologa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits

Comment thread internal/env/env.go Outdated
Comment thread internal/env/env.go
Comment thread internal/env/env.go
Moritz Clasmeier added 3 commits March 9, 2026 09:33
…ng it from being run as part of the unit tests (which would fail with the new panicing behaviour)
@mclasmeier
Copy link
Copy Markdown
Collaborator Author

@vladbologa Addressed two comments, one is unclear to me. I had to touch one existing existing integration test, which would panic with the new behaviour when executed without valid kubectl context.

@mclasmeier mclasmeier requested a review from vladbologa March 9, 2026 09:01
Comment thread internal/env/env.go Outdated
@mclasmeier mclasmeier requested a review from vladbologa March 9, 2026 13:13
@mclasmeier mclasmeier merged commit a1a2e9f into main Mar 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants