chore: various improvements#56
Merged
Merged
Conversation
porridge
force-pushed
the
porridge/review-simple
branch
from
642e42e to
d7e8794
Compare
mclasmeier
approved these changes
Feb 18, 2026
Collaborator
mclasmeier
left a comment
mclasmeier
left a comment
There was a problem hiding this comment.
Just few minor comments. 👍
These just repeat what is obvious from the line which follows.
These are likely not needed. If they are, synchronization should not be time-based.
porridge
force-pushed
the
porridge/review-simple
branch
from
d7e8794 to
03a144f
Compare
No need for explicit deferred cleanup then.
# Conflicts: # internal/deployer/operator.go
porridge
force-pushed
the
porridge/review-simple
branch
from
03a144f to
9d6b88c
Compare
mclasmeier
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review commit-by commit.
Each represents a self-contained change and each of them should be merge-worthy as is.