Rework override handling to properly support combined deployments#62
Merged
Conversation
mclasmeier
force-pushed
the
mc/combined-overrides
branch
from
50f4e02 to
26ee8ee
Compare
1. When deplying both components combined, then the override file need to be structured as follows: central: <overrides for central> securedCluster: <overrides for secured cluster> And the set expressions need to be similar: --set central.foo=bar --set securedCluster.foo=bar 2. When deploying components individually, this extra nesting must be skipped (behaviour as of now). So, essentially this is fixing the overrides for combined deployments.
porridge
approved these changes
Mar 16, 2026
mclasmeier
force-pushed
the
mc/combined-overrides
branch
from
26ee8ee to
4925dbb
Compare
porridge
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, when deploying both components combined, then the override file need to be structured as follows:
And the set expressions need to be similar:
--set central.foo=bar--setsecuredCluster.foo=bar.Whereas when deploying components individually, this extra nesting must be skipped (behaviour as of now).
Before this change
--overridewas practically dysfunctional for combined deployments.