Add --features flag for setting ACS feature flags#77
Merged
Conversation
28f3bdb to
55eb5fe
Compare
mclasmeier
reviewed
Mar 30, 2026
Collaborator
mclasmeier
left a comment
There was a problem hiding this comment.
Very cool, thank you for picking this up.
I believe we can simplify in a few places, but no fundamental concerns.
- Use slices.Concat to unify loop in mergeEnvVars - Sort envVars output alphabetically for deterministic results - Add test case for alphabetical ordering - Improve comment on mergeWithEnvVarSupport - Refactor mergeWithEnvVarSupport to use k8s.io/apimachinery/unstructured
c8522a6 to
1b6dd65
Compare
mclasmeier
approved these changes
Mar 30, 2026
Collaborator
mclasmeier
left a comment
There was a problem hiding this comment.
I was thinking, maybe also check if --feature-flags has been used together with --helm and if that is the case just error out, telling the user that this is not supported?
Co-authored-by: Moritz Clasmeier <111092021+mclasmeier@users.noreply.github.com>
Contributor
Author
|
@mclasmeier I also added in a check to see if someone is trying to use --helm with --features and log an error. Great suggestions so far! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--featuresflag toroxie deploythat provides a convenient syntax for enabling/disabling ACS feature flags without needing to create override files.Closes #34
Note - The
--featuresflag currently only works with operator-based deployments (the default). It does not apply feature flags when using--helmmode. Since--helmis a hidden/experimental flag with different values structure, Helm support is deferred to a future PR if needed.Usage
Feature flags apply to both Central and SecuredCluster components.
How it works
Feature flags provided with
--featureshave the highest precedence and override values from--overridefiles and--setexpressions.Feature flags merge with existing
.spec.customize.envVarsby name, not by replacing the entire array. This means:--features +ROX_FOOwill overrideROX_FOOif it exists in an override fileTesting
Manually tested the following cases: