-
Notifications
You must be signed in to change notification settings - Fork 170
ROX-26375: remove ability to rollback to release older than 4.3 #12801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Images are ready for the commit at c4efd0d. To use with deploy scripts, first |
e57fc48 to
cfd63e6
Compare
6d8fd22 to
3e91808
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12801 +/- ##
==========================================
+ Coverage 48.23% 48.25% +0.01%
==========================================
Files 2442 2442
Lines 175411 175485 +74
==========================================
+ Hits 84615 84677 +62
- Misses 83984 83996 +12
Partials 6812 6812
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@dashrews78: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Ran CI before changing the upgrade test to verify it failed trying to rollback to 4.1.
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/stackrox_stackrox/12801/pull-ci-stackrox-stackrox-master-gke-upgrade-tests/1838659525264019456