Skip to content

Conversation

@dashrews78
Copy link
Contributor

@dashrews78 dashrews78 commented Sep 24, 2024

Description

change me!

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Ran CI before changing the upgrade test to verify it failed trying to rollback to 4.1.
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/stackrox_stackrox/12801/pull-ci-stackrox-stackrox-master-gke-upgrade-tests/1838659525264019456

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Sep 24, 2024

Images are ready for the commit at c4efd0d.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-637-gc4efd0dcbe.

@dashrews78 dashrews78 changed the title WIP chore(cleanup): remove ability to rollback to 4.1 WIP ROX-26375: remove ability to rollback to release older than 4.3 Sep 24, 2024
@dashrews78 dashrews78 changed the title WIP ROX-26375: remove ability to rollback to release older than 4.3 ROX-26375: remove ability to rollback to release older than 4.3 Sep 24, 2024
@dashrews78 dashrews78 requested a review from a team as a code owner September 25, 2024 18:32
@dashrews78 dashrews78 force-pushed the dashrews/chore-no-rollback-4-1 branch from e57fc48 to cfd63e6 Compare September 30, 2024 20:04
74adc9e bump minimum rollback to 4.2
c9c5ebb change it to minimum of 4.3
8328dd5 test update
cfd63e6 update the upgrade test
9b20bbe go mod
8945edb simply try to pull roxctl
a5da56f switch to bucket
1336715 make the directory
b2ca58f annoying
6d8fd22 try again
@dashrews78 dashrews78 force-pushed the dashrews/chore-no-rollback-4-1 branch from 6d8fd22 to 3e91808 Compare October 2, 2024 18:17
@codecov
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.25%. Comparing base (d20bca1) to head (c4efd0d).
Report is 71 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12801      +/-   ##
==========================================
+ Coverage   48.23%   48.25%   +0.01%     
==========================================
  Files        2442     2442              
  Lines      175411   175485      +74     
==========================================
+ Hits        84615    84677      +62     
- Misses      83984    83996      +12     
  Partials     6812     6812              
Flag Coverage Δ
go-unit-tests 48.25% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2024

@dashrews78: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-upgrade-tests c4efd0d link false /test gke-upgrade-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dashrews78 dashrews78 closed this Oct 11, 2024
@dashrews78 dashrews78 deleted the dashrews/chore-no-rollback-4-1 branch September 10, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants