Skip to content

Conversation

@dcaravel
Copy link
Contributor

Description

change me!

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 60e7a24.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-600-g60e7a24c1a.

@codecov
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 91.83673% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.20%. Comparing base (1b68af5) to head (60e7a24).

Files with missing lines Patch % Lines
central/image/service/service_impl.go 91.30% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12835      +/-   ##
==========================================
+ Coverage   48.15%   48.20%   +0.04%     
==========================================
  Files        2439     2439              
  Lines      175103   175140      +37     
==========================================
+ Hits        84324    84418      +94     
+ Misses      83978    83914      -64     
- Partials     6801     6808       +7     
Flag Coverage Δ
go-unit-tests 48.20% <91.83%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-ci
Copy link

openshift-ci bot commented May 22, 2025

@dcaravel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-ui-e2e-tests 60e7a24 link true /test gke-ui-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dcaravel dcaravel closed this May 23, 2025
@dcaravel dcaravel deleted the dc/reproc-local branch September 11, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants