chore(lint): enable the usestdlibvars linter #17129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Juneezee. Thanks for your PR. I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
github-actions
bot
added
the
external-contributor
janisz
approved these changes
Oct 4, 2025
This was referenced Oct 6, 2025
Contributor
Contributor
|
I'm sorry I accidentally closed this PR. I'm working on #17160 to make CI 🟢 Stay tuned 😅 |
Part of #7729. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
janisz
force-pushed
the
chore/usestdlibvars
branch
from
3c1b58b to
0eeccbd
Compare
Contributor
|
/ok-to-test |
Contributor
|
Caution There are some errors in your PipelineRun template.
|
Contributor
|
/ok-to-test |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `scanner/enricher/nvd/nvd.go:424` </location>
<code_context>
Str("nvd_message", req.Header.Get("message")).
Msg("NVD response")
- if resp.StatusCode != 200 {
+ if resp.StatusCode != http.StatusOK {
_ = resp.Body.Close
return nil, fmt.Errorf("unexpected status code when querying %s: %d", req.URL.String(), resp.StatusCode)
</code_context>
<issue_to_address>
**issue (bug_risk):** The response body is not being closed properly on error.
'_ = resp.Body.Close' does not close the body; use 'resp.Body.Close()' to properly release resources.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
@janisz Should I retest? |
Contributor
|
/retest |
jvdm
approved these changes
Oct 7, 2025
|
@Juneezee: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
janisz
changed the title
janisz
added
the
auto-retest
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17129 +/- ##
=======================================
Coverage 48.83% 48.83%
=======================================
Files 2716 2716
Lines 203240 203240
=======================================
+ Hits 99252 99254 +2
+ Misses 96169 96168 -1
+ Partials 7819 7818 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/ok-to-test |
Contributor
|
/retest |
Contributor
|
@Juneezee Thank You! I'm sorry for the delayed merge 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #7729.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI jobs