-
Notifications
You must be signed in to change notification settings - Fork 172
ROX-32716: Update auth header logic for plugin #18578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
|
Images are ready for the commit at 353ec07. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18578 +/- ##
=======================================
Coverage 49.13% 49.13%
=======================================
Files 2651 2651
Lines 199124 199124
=======================================
+ Hits 97830 97839 +9
+ Misses 93878 93871 -7
+ Partials 7416 7414 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6658010 to
9b97c41
Compare
d5e501c to
436a8c1
Compare
436a8c1 to
353ec07
Compare
Description
Updates the auth header logic to conform with the agreed upon behavior.
Bonus: Thanks @pedrottimark for your comment on the need to explicitly call
useNamespaceScope(). That was a leftover from a previous draft where we needed to do the same with the deployment scope as well. Since this is no longer needed, we can actually remove all explicit calls that set the namespace hook.User-facing documentation
Testing and quality
Automated testing
How I validated my change
Updated unit tests.
Inspect the Network console and verify:
ACS-AUTH-NAMESPACE-SCOPEis not set at all on metadata/permissions/featureflags requestsACS-AUTH-NAMESPACE-SCOPEis set to the currently selected namespace on data requestsACS-AUTH-NAMESPACE-SCOPEis set to'*'when the "All projects" dropdown option is selected