ROX-19064: Scanner V4 Automated Tests (Groovy Foundation)#19640
ROX-19064: Scanner V4 Automated Tests (Groovy Foundation)#19640
Conversation
Add null guard to found checks so that it actually retries when image not found yet vs. failing with NullPointerException. This was causing CI flakes during testing.
…y flag - Creates a ScannerV4Integration type for tests to use (will be part of future commits) - The Scanner V4 integration cannot be deleted in Central by design, the new isDeletable() method allows tests to act accordingly. - Makes isTestable() for StackRoxScannerIntegration conditional on Scanner V4 being enabled. When Scanner V4 is enabled StackRox Scanner is not reachable for image scans (exception: delegated scanning, but that is not tested in groovy tests)
|
Skipping CI for Draft Pull Request. |
|
/test all |
|
Images are ready for the commit at 07257dc. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19640 +/- ##
==========================================
- Coverage 49.37% 49.37% -0.01%
==========================================
Files 2742 2742
Lines 206921 206921
==========================================
- Hits 102165 102159 -6
- Misses 97172 97176 +4
- Partials 7584 7586 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Appears to be a flake unrelated to this PRs changes, image scan failed: Additionally the previous run succeeded when PR was in draft w/o any changes. |
|
/test gke-qa-e2e-tests |
Description
First in a series of changes that modify groovy tests to work with both
StackRox ScannerandScanner V4.Scanner V4 is not enabled yet, this is prep work so that it can be enabled in a future PR.
This PR includes 'foundational' changes that will be the base for future stacked PRs that modify tests.
scannerV4Enabledflag is added so that tests can react accordingly, it's populated by querying Feature Flags from Central's APIScannerV4Integrationtype will be used by various tests in future PRs.NullPointerExceptionbug inwaitForVulnerabilitiesForImage()that was leading to flakes because retires were not occuring (observed while testing).User-facing documentation
Testing and quality
Automated testing
How I validated my change
Against StackROX Scanner these changes will be tested by CI as part of this and subsequent PRs
Against Scanner V4 these changes were validated in #19236