Skip to content

ROX-34094: Remove PDF export artifacts from VulnMgmt pages#20663

Merged
sachaudh merged 2 commits into
masterfrom
ROX-34094-remove-vulnmgmt-pdf-export
May 18, 2026
Merged

ROX-34094: Remove PDF export artifacts from VulnMgmt pages#20663
sachaudh merged 2 commits into
masterfrom
ROX-34094-remove-vulnmgmt-pdf-export

Conversation

@sachaudh
Copy link
Copy Markdown
Contributor

@sachaudh sachaudh commented May 18, 2026

Description

Jira: ROX-34094

As part of the jspdf removal effort (ROX-34090), this PR cleans up PDF export artifacts from the Vulnerability Management 1.0 pages. CSS classes like pdf-page, pdf-stretch, and pdf-new were applied to elements across entity overview and widget components for PDF capture, and the EntityList component called createPDFTable from pdfUtils on every render via useLayoutEffect. With the PDF export feature being removed, these are now dead code.

  • Remove all pdf-page, pdf-stretch, and pdf-new CSS class references from VulnMgmt entity overviews and widgets
  • Remove createPDFTable import and useLayoutEffect call from EntityList
  • Remove id="capture-list" and id="capture-widgets" attributes used only for PDF capture
  • Remove unused pdfId variable from WorkflowEntityPageLayout
  • Remove redundant wrapper div around OverviewComponent in WorkflowEntityPage
  • Remove outdated comment referencing pdfUtils.js in ListCVEs.utils.test.js

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • modified existing tests

How I validated my change

  • Verified linting and type checking pass on all modified files
  • Confirmed the existing ListCVEs.utils.test.js test suite passes without the removed comment block
  • Changes are purely cosmetic (removing dead CSS classes and unused code) with no logic changes -- existing tests cover the affected components

sachaudh added 2 commits May 15, 2026 09:03
…nagement pages

PDF export is being removed from the UI. This cleans up all VulnMgmt
references: createPDFTable usage, pdfId/capture-* IDs, and pdf-page/
pdf-stretch/pdf-new CSS classes across lists, entity overviews, and
widgets. CSV export remains unaffected.

Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
The inner div only existed to carry the `id="capture-widgets"` attribute
for PDF export. With that ID removed, the div is a pure passthrough --
the parent flex container already provides sizing.

Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sachaudh sachaudh changed the title ROX-34094: Remove PDF export artifacts from Vulnerability Management pages ROX-34094: Remove PDF export artifacts from VulnMgmt pages May 18, 2026
@sachaudh sachaudh marked this pull request as ready for review May 18, 2026 18:07
@sachaudh sachaudh requested a review from a team as a code owner May 18, 2026 18:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

🚀 Build Images Ready

Images are ready for commit 5b6d53b. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-1032-g5b6d53b0e9

Copy link
Copy Markdown
Contributor

@dvail dvail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't on the other reviews, but LGTM if the CSS classes removed were referenced in a previous PR. 🚢

@sachaudh
Copy link
Copy Markdown
Contributor Author

sachaudh commented May 18, 2026

I wasn't on the other reviews, but LGTM if the CSS classes removed were referenced in a previous PR. 🚢

Yep, confirmed. The VulnMgmt PDF export button was actually removed back in August 2023 in #7489, but the CSS classes (pdf-page, pdf-stretch, pdf-new) and element IDs (capture-list, capture-widgets) got left behind. So these have been dead code in VulnMgmt for a while now.

The same classes still exist in ConfigManagement and Compliance for their own PDF export features, but those are untouched by this stack.

@sachaudh sachaudh merged commit 5b6d53b into master May 18, 2026
102 of 104 checks passed
@sachaudh sachaudh deleted the ROX-34094-remove-vulnmgmt-pdf-export branch May 18, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants