ROX-34094: Remove PDF export artifacts from VulnMgmt pages#20663
Conversation
…nagement pages PDF export is being removed from the UI. This cleans up all VulnMgmt references: createPDFTable usage, pdfId/capture-* IDs, and pdf-page/ pdf-stretch/pdf-new CSS classes across lists, entity overviews, and widgets. CSV export remains unaffected. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
The inner div only existed to carry the `id="capture-widgets"` attribute for PDF export. With that ID removed, the div is a pure passthrough -- the parent flex container already provides sizing. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
|
Skipping CI for Draft Pull Request. |
🚀 Build Images ReadyImages are ready for commit 5b6d53b. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-1032-g5b6d53b0e9 |
dvail
left a comment
There was a problem hiding this comment.
I wasn't on the other reviews, but LGTM if the CSS classes removed were referenced in a previous PR. 🚢
Yep, confirmed. The VulnMgmt PDF export button was actually removed back in August 2023 in #7489, but the CSS classes ( The same classes still exist in ConfigManagement and Compliance for their own PDF export features, but those are untouched by this stack. |
Description
Jira: ROX-34094
As part of the jspdf removal effort (ROX-34090), this PR cleans up PDF export artifacts from the Vulnerability Management 1.0 pages. CSS classes like
pdf-page,pdf-stretch, andpdf-newwere applied to elements across entity overview and widget components for PDF capture, and theEntityListcomponent calledcreatePDFTablefrompdfUtilson every render viauseLayoutEffect. With the PDF export feature being removed, these are now dead code.pdf-page,pdf-stretch, andpdf-newCSS class references from VulnMgmt entity overviews and widgetscreatePDFTableimport anduseLayoutEffectcall fromEntityListid="capture-list"andid="capture-widgets"attributes used only for PDF capturepdfIdvariable fromWorkflowEntityPageLayoutdivaroundOverviewComponentinWorkflowEntityPagepdfUtils.jsinListCVEs.utils.test.jsUser-facing documentation
Testing and quality
Automated testing
How I validated my change
ListCVEs.utils.test.jstest suite passes without the removed comment block