ROX-32944: add caller hint to cursor names for traceability#20756
Open
dashrews78 wants to merge 2 commits into
Open
ROX-32944: add caller hint to cursor names for traceability#20756dashrews78 wants to merge 2 commits into
dashrews78 wants to merge 2 commits into
Conversation
Cursor names now include the calling method (e.g. Walk, WalkByQuery,
WalkMetadataByQuery) between the table name and random suffix, making
them traceable in pg_stat_activity. Format: {table}_{hint}_{random4}.
Also reduced random suffix from 16 to 4 chars since cursors only need
uniqueness within a single transaction.
Partially generated by AI
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
Contributor
🚀 Build Images ReadyImages are ready for commit 6a571df. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-1099-g6a571dfacb |
roxvet requires pkg/sync over stdlib sync, and golangci-lint modernize linter requires WaitGroup.Go over Add+go func+Done. Partially generated by AI Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ajheflin
approved these changes
May 21, 2026
Contributor
Author
|
/retest |
Contributor
Author
|
/test checks |
|
@dashrews78: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
Author
|
/test create-custom-snapshot |
|
@dashrews78: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cursor names now include the calling method (e.g. Walk, WalkByQuery,
WalkMetadataByQuery) between the table name and random suffix, making
them traceable in pg_stat_activity. Format: {table}{hint}{random4}.
Also reduced random suffix from 16 to 4 chars since cursors only need
uniqueness within a single transaction.
Partially generated by AI
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
User-facing documentation
Testing and quality
Automated testing
How I validated my change
The unit test should be sufficient here.