Skip to content

feat(ui): VM Reporting 2.0 GA Major Fixes#7652

Merged
sachaudh merged 1 commit intomasterfrom
ROX-19311
Sep 6, 2023
Merged

feat(ui): VM Reporting 2.0 GA Major Fixes#7652
sachaudh merged 1 commit intomasterfrom
ROX-19311

Conversation

@sachaudh sachaudh changed the title feat(ui): VM Reporting 2.0 GA Fixes feat(ui): VM Reporting 2.0 GA Major Fixes Aug 31, 2023
@sachaudh sachaudh force-pushed the ROX-19311 branch 2 times, most recently from afd1115 to 2c10534 Compare August 31, 2023 01:13
@sachaudh
Copy link
Copy Markdown
Contributor Author

@zhenpesky take a look at the video for the 2nd bug fix. Let me know if that is the behavior you were looking for for the distribution list issue

@ghost
Copy link
Copy Markdown

ghost commented Aug 31, 2023

Images are ready for the commit at afeb6d9.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.2.x-77-gafeb6d9ee9.

@zhenpesky
Copy link
Copy Markdown

@sachaudh

1. On issue 18884 - Distribution list): Missing a conditional behavior:

  • After clicking "Reset to default", the button should be disabled in grey text.
  • The button is enabled (blue text) as the user typing in the custom input (for example: similar behavior while the user typing in a search box component and showing the "X" icon).
  • Show the button "Reset to default" in grey text if a notifier is selected without any custom input.
  1. On issue 19318): The inline alert (in step 2) text does not match the updated option text (in step 1): "Last scheduled report that was successfully sent"

Copy link
Copy Markdown

@zhenpesky zhenpesky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment above: fixes needed on issue 18884 and on issue 19318

@sachaudh
Copy link
Copy Markdown
Contributor Author

@zhenpesky made the changes you suggested. Here are some clips:

Screen.Recording.2023-08-31.at.4.17.55.PM.mov
Screenshot 2023-08-31 at 4 18 50 PM

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Sep 5, 2023

@sachaudh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-ui-e2e-tests afeb6d9 link false /test gke-ui-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sachaudh sachaudh disabled auto-merge September 6, 2023 16:09
@sachaudh sachaudh merged commit cc3bef3 into master Sep 6, 2023
@sachaudh sachaudh deleted the ROX-19311 branch September 6, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants