Skip to content

Conversation

@hugoclrd
Copy link
Contributor

@hugoclrd hugoclrd commented Mar 27, 2024

Description

  • Update @hirosystems/clarinet-sdk and vitest-environment-clarinet to v2
    • The clarinet-sdk now relies on the deployment plan (default.simnet-plan.yaml) hence why there's this new file
  • Also updated vite and vitest as part of this PR
    • Adapt the vitest config

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

We're currently using those also in stacks-network/stacks-core#4550.

Copy link
Contributor

@MarvinJanssen MarvinJanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hugocaillard!

@MarvinJanssen MarvinJanssen merged commit 7c8dd84 into stacks-network:main Apr 2, 2024
@MarvinJanssen
Copy link
Contributor

Apologies @hugocaillard could you update packages/clarunit/CHANGELOG.md as well?

@hugoclrd
Copy link
Contributor Author

hugoclrd commented Apr 2, 2024

Hey @MarvinJanssen
Happy to, but I'm used to updating changelog on release, and this PR didn't update the version.
Do you want this PR to also bump the version?
Since you're recommending conventional commit, would you consider using something like

Definitely don't want to overkill of course, let's take the simplest solution

@MarvinJanssen
Copy link
Contributor

I think it is necessary to publish the changes to npm. Perhaps @wileyj can chime in since he set it up.

@hugoclrd
Copy link
Contributor Author

hugoclrd commented Apr 3, 2024

Ok indeed it looks like neither of us can publish. Could be nice to have it in the CI

@wileyj wileyj mentioned this pull request Apr 3, 2024
@wileyj
Copy link
Contributor

wileyj commented Apr 3, 2024

@hugocaillard @MarvinJanssen published (we have an issue to autopublish, low priority recently): https://www.npmjs.com/package/@stacks/clarunit

@hugoclrd
Copy link
Contributor Author

hugoclrd commented Apr 3, 2024

Thanks @wileyj
Can you push the version bump on github as well? thx

@wileyj
Copy link
Contributor

wileyj commented Apr 3, 2024 via email

@MarvinJanssen
Copy link
Contributor

Thanks @wileyj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants