Add support for macOS and allow building stacks-core from commit hash by radu-stacks · Pull Request #39 · stacks-network/hacknet

radu-stacks · 2026-05-12T10:28:47Z

Continuation of #29 which became stale.

CLAassistant · 2026-05-12T10:29:02Z

All committers have signed the CLA.

Co-authored-by: Radu Bahmata <92028479+BowTiedRadone@users.noreply.github.com>

radu-stacks · 2026-05-12T10:36:45Z

The @ASuciuX email address was mapping to @BowTiedDeployer which didn't sign the CLA. To allow this PR to be merged I rebased the commits, replacing the email address with the no-reply one and signed with my signature. Hope that's ok @wileyj.

wileyj · 2026-05-12T19:41:12Z

-RUN git clone --branch $STACKS_CORE_BASE_BRANCH --single-branch --depth=1 https://github.com/stacks-network/stacks-core.git /code/stacks-core
 WORKDIR /code/stacks-core
-RUN apt-get update && apt-get install -y git libclang-dev llvm
+RUN apt-get update && apt-get install -y libclang-dev llvm


this ordering is weird (and is present in the default branch, so i'll take ownership for this lol).

i think we should move the apt-get commands to the top of the file before starting the git clone/init. i also think we should keep the git package install. it may be present in the current base image rust:bookworm, but there is no promise that it will always be present there.

wileyj · 2026-05-12T19:42:17Z

  - &REWARD_RECIPIENT_2 ${REWARD_RECIPIENT_2:-ST2FW15NGB4H76FMVXKHYYSM865YVS6V3SA1GNABC} # priv: fe3087801196d8027008146b13e6d365920c2e4b7bc9969729ec2f0f22ef74fc01
  - &REWARD_RECIPIENT_3 ${REWARD_RECIPIENT_3:-ST2MES40ZEXTX9M4YXW9QSWHRVC9HYT419S198VPM} # priv: ed7eb063c61b8e892987228f1fcfb74eab5009568861613dc4b074b708a7893701
-  - &STACKS_CORE_BASE_BRANCH ${STACKS_CORE_BASE_BRANCH:-3.4.0.0.1}
+  - &STACKS_CORE_BASE_BRANCH ${STACKS_CORE_BASE_BRANCH:-3.4.0.0.1} # branch, tag, or commit SHA


Suggested change

- &STACKS_CORE_BASE_BRANCH ${STACKS_CORE_BASE_BRANCH:-3.4.0.0.1} # branch, tag, or commit SHA

- &STACKS_CORE_BASE_BRANCH ${STACKS_CORE_BASE_BRANCH:-3.4.0.0.2} # branch, tag, or commit SHA

bump to latest version

wileyj · 2026-05-12T19:45:08Z

+    # restores archive ownership and leaves bind-mount sources unwritable.
+    # Extract as the current user so everything lands user-owned.
+    TAR_EXTRACT := tar -xf
+else


this should be sufficient, but we should add a disclaimer in the README that this Makefile will only work on linux/macos. if someone were to run this on windows for example, this else section would fail.

i think it's ok, but better to document that only linux/macos are supported here.

wileyj · 2026-05-12T19:55:10Z

+$(CHAINSTATE_DIR):
+	@if [ ! -d "$(CHAINSTATE_DIR)" ]; then \
+		mkdir -p $(CHAINSTATE_DIR); \
+		if [ "$(TARGET)" = "up" ]; then \
+			if [ -f "$(CHAINSTATE_ARCHIVE)" ]; then \
+				$(TAR_EXTRACT) $(CHAINSTATE_ARCHIVE) -C $(CHAINSTATE_DIR) || exit 1; \
+			else \
+				echo "Chainstate archive ($(CHAINSTATE_ARCHIVE)) not found. Exiting"; \
+				rm -rf $(CHAINSTATE_DIR); \
+				exit 1; \
+			fi; \
+		fi; \


can this section be changed to conform to the original syntax? requiring an escape on each line of the conditional is not ideal.

wileyj · 2026-05-12T19:56:35Z

 # Boot the network from a local chainstate archive
 up: check-not-running | build $(CHAINSTATE_DIR)
 	@echo "Starting $(PROJECT) network from chainstate archive"
+	@echo "  OS: $(OS)"


nit, but i would use UNAME_S here since it's the data directly from the system vs a hardcoded value

wileyj · 2026-05-12T19:58:56Z

 	docker compose -f docker/docker-compose.yml --profile default -p $(PROJECT) down
 	@if [ -f .current-chainstate-dir ]; then \
-		rm -f .current-chainstate-dir
+		rm -f .current-chainstate-dir; \


same comment as before- is there a compelling reason to keep the ; \ chars here? does macos make handle the existing syntax differently?

adding these is not wrong necessarily, but it does add maintenance overhead and errors won't be apparent (e.g. you make a change and forget to add the ; \ where needed in the proposed syntax change.

wileyj · 2026-05-12T19:59:08Z

 	docker compose -f docker/docker-compose.yml --profile default -p $(PROJECT) down
 	@if [ -f .current-chainstate-dir ]; then \
-		rm -f .current-chainstate-dir
+		rm -f .current-chainstate-dir; \


see line 145 comment

to reduce spam - assume this applies to all other similar changes, as i see several more

wileyj · 2026-05-12T20:01:52Z

The @ASuciuX email address was mapping to @BowTiedDeployer which didn't sign the CLA. To allow this PR to be merged I rebased the commits, replacing the email address with the no-reply one and signed with my signature. Hope that's ok @wileyj.

i see @ASuciuX is credited as co-author so it's perfectly fine

feat: add mac os support

fd26fbd

radu-stacks requested a review from wileyj May 12, 2026 10:28

radu-stacks changed the title ~~This PR adds support for macOS and allows building stacks-core from commit hash~~ Add support for macOS and allows building stacks-core from commit hash May 12, 2026

ASuciuX and others added 3 commits May 12, 2026 13:34

feat: support for running stacks node from commit

36ab6fe

Update docker/stacks/Dockerfile

ba0aaed

Co-authored-by: Radu Bahmata <92028479+BowTiedRadone@users.noreply.github.com>

Run tar as same user on macOS

b78fbfb

radu-stacks force-pushed the feat/mac-os-support branch from 207ea2f to b78fbfb Compare May 12, 2026 10:34

radu-stacks mentioned this pull request May 12, 2026

Feat(support): mac os + stacks node from commit #29

Closed

radu-stacks changed the title ~~Add support for macOS and allows building stacks-core from commit hash~~ Add support for macOS and allow building stacks-core from commit hash May 12, 2026

wileyj reviewed May 12, 2026

View reviewed changes

Comment thread Makefile

wileyj reviewed May 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for macOS and allow building stacks-core from commit hash#39

Add support for macOS and allow building stacks-core from commit hash#39
radu-stacks wants to merge 4 commits into
stacks-network:masterfrom
radu-stacks:feat/mac-os-support

radu-stacks commented May 12, 2026

Uh oh!

CLAassistant commented May 12, 2026 •

edited

Loading

Uh oh!

radu-stacks commented May 12, 2026 •

edited

Loading

Uh oh!

wileyj May 12, 2026

Uh oh!

wileyj May 12, 2026

Uh oh!

wileyj May 12, 2026

Uh oh!

Uh oh!

wileyj May 12, 2026

Uh oh!

wileyj May 12, 2026

Uh oh!

wileyj May 12, 2026

Uh oh!

wileyj May 12, 2026

Uh oh!

wileyj May 12, 2026

Uh oh!

wileyj commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	- &STACKS_CORE_BASE_BRANCH ${STACKS_CORE_BASE_BRANCH:-3.4.0.0.1} # branch, tag, or commit SHA
	- &STACKS_CORE_BASE_BRANCH ${STACKS_CORE_BASE_BRANCH:-3.4.0.0.2} # branch, tag, or commit SHA

Conversation

radu-stacks commented May 12, 2026

Uh oh!

CLAassistant commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

radu-stacks commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wileyj commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented May 12, 2026 •

edited

Loading

radu-stacks commented May 12, 2026 •

edited

Loading