Skip to content

removed unused env var SIGNER_APPROVAL_THRESHOLD#7

Merged
BowTiedRadone merged 2 commits intomasterfrom
fix/remove_env_var
Sep 17, 2025
Merged

removed unused env var SIGNER_APPROVAL_THRESHOLD#7
BowTiedRadone merged 2 commits intomasterfrom
fix/remove_env_var

Conversation

@wileyj
Copy link
Copy Markdown
Contributor

@wileyj wileyj commented Sep 17, 2025

missed this env var in the last PR . it's not needed except when using a very specific patch to the stacsk-node that allows a lower threshhold to the signer

Copy link
Copy Markdown
Contributor

@BowTiedRadone BowTiedRadone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment, there seem to be some leftovers.

Comment thread docker/docker-compose.yml
Copy link
Copy Markdown
Contributor

@BowTiedRadone BowTiedRadone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BowTiedRadone BowTiedRadone merged commit 542cb35 into master Sep 17, 2025
@BowTiedRadone BowTiedRadone deleted the fix/remove_env_var branch September 17, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants