More noisy neighbors #1971
Description
Is your feature request related to a problem? Please describe.
Following up on #1912, neighbors.rs is still flooding the screen with messages, this time while trying to connect to itself. A few others in Discord are reporting the same problem.
From @jcnelson in Discord:
that's fine -- it just means that the node tried to connect to itself (and got the net::Error::Denied error)
maybe it shouldn't be info-level
(generally speaking, the node won't try to connect to 0.0.0.0)
Describe the solution you'd like
I would like to change the output so this message only shows at debug level, not info level. A PR will follow.
Describe alternatives you've considered
Same with the last issue, the goal is to create a clean and easier to read log at the info level, while still showing this information if debug is enabled.
An alternative would be to check if the error happens when connecting to itself versus connecting to a different address, and only displaying the info-level message if the address is not 0.0.0.0 or pub=None. At this point, simple seems better?
Additional context
Error text:
INFO [1602251990.602] [src/net/neighbors.rs:2003] [ThreadId(8)] local.80000000://(bind=V4(0.0.0.0:20444)) (pub=None): Failed to check connection to facade01+80000000://V4(0.0.0.0:20444): Denied
Screenshot:
