Fix 1984 #1985
Merged
Fix 1984 #1985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
October 13, 2020 10:39
… should fill in missing bytes with 0
psq
approved these changes
Oct 21, 2020
Contributor
psq
left a comment
psq
left a comment
There was a problem hiding this comment.
will no longer panic on a bad hash param
kantai
reviewed
Oct 21, 2020
src/vm/types/mod.rs
Outdated
| if let Value::Sequence(SequenceData::Buffer(mut buffdata)) = self { | ||
| if buffdata.data.len() <= sz { | ||
| for _ in buffdata.data.len()..sz { | ||
| buffdata.data.push(0u8) |
Contributor
There was a problem hiding this comment.
Since these expect_ functions are basically destructuring routines, it makes more sense for data padding to happen in the caller rather than in this function (a destructuring routine shouldn't mutate the returned data).
PoX: Two reward addresses per block
kantai
approved these changes
Oct 21, 2020
Contributor
kantai
left a comment
kantai
left a comment
There was a problem hiding this comment.
LGTM! Before performing a chain reset, can you also merge next to master?
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value::expect_buff(x)should work or buffers with fewer thanxbytes.