Fix 1934: mix burn block height into microblock pubkey #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcnelson
approved these changes
Nov 11, 2020
Member
jcnelson
left a comment
jcnelson
left a comment
There was a problem hiding this comment.
LGTM. Can you test it on the testnet before merging?
Contributor
Author
|
Yep -- tested this on testnet, and my miner successfully mined a handful of blocks |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1934 by mixing the burn block height into the microblock private key rotation. When attempting RBF, don't rotate the private key (this is just to make testing more deterministic).
Type of Change
Bug fix
Does this introduce a breaking change?
No
Are documentation updates required?
No
Testing information
These changes are covered in existing tests, and required updating two tests' "find_microblock_key" logic.